Feature: Allow other plugins to register tasks to produce junit reports #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozco
force-pushed
the
fo/junit-reports-ext
branch
from
4e004f7
to
d57444c
Compare
CRogers
reviewed
May 18, 2021
gradle-junit-reports/src/main/java/com/palantir/gradle/junit/JunitTaskResultExtension.java
Show resolved
Hide resolved
CRogers
reviewed
May 18, 2021
gradle-junit-reports/src/main/java/com/palantir/gradle/junit/JunitReportsFinalizer.java
Outdated
Show resolved
Hide resolved
robert3005
reviewed
May 19, 2021
...aseline-java/src/test/groovy/com/palantir/baseline/BaselineCircleCiJavaIntegrationTests.java
Outdated
Show resolved
Hide resolved
robert3005
reviewed
May 19, 2021
robert3005
reviewed
May 19, 2021
gradle-junit-reports/src/main/java/com/palantir/gradle/junit/JunitReportsFinalizer.java
Outdated
Show resolved
Hide resolved
added 5 commits
May 20, 2021 10:31
Generate changelog in
|
|
@CRogers @robert3005 this is ready for another look |
|
👍 |
This was referenced Jun 22, 2021
Closed
This was referenced Jun 22, 2021
Merged
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
It was very difficult for custom tasks to leverage gradle-baesline to produce junit XML resulting in errors not being surfaced cleanly at CI.
After this PR
==COMMIT_MSG==
Allow other plugins to register tasks to produce junit reports
==COMMIT_MSG==
The idea is that another plugin could use
JunitTaskResultExtensionto register a failure reporter for a task they have createdPossible downsides?